> non-platform plugin creates and uses custom widget (subclass) which is based > To do that, we want to style (almost) all widgets in general-if, e.g., a > platforms with maintainable and simple CSS. > achieve is a way to make Eclipse look good with light and dark themes on all > currently do will never lead to the perfect result, because what we try to > In a more general discussion, I think that CSS styling at the level we > and it is quite some effort to get it right on all platforms). > workarounds and which ones are not - this is not always clear from the CSS > could help here, because he has the most knowledge about which parts are > the meantime in there to simplify a bit. > original CSS and remove the workarounds for the bug which have been fixed in > But I don't have objections against reverting the commit and take the > fresh start to which we would add specific rules again as needed. I had hoped that the overly simplified version could be > wanted to create an experimental additional theme to try out things in the > I have feared that the simplification would be too much (which is why I (In reply to Stefan Winkler from comment #12) tData("", Boolean.TRUE)Ī more flexible solution could be to define common colors (similar to SWT.WIDGET_FOREGROUND) which can be modified using CSS - or, as has been proposed by different people during the past months and years - we could move parts of the CSS engine down to the SWT level and use this to modify the SWT.xxx constants. ) to do styling.Ī simple solution would be an opt-in or opt-out of theme styling with something like In fact, both requirements are in conflict. There might actually be widget the user does not want to be styled by the theme. > I'm loathe to use '*' rules since it affects custom widgets that assume To do that, we want to style (almost) all widgets in general-if, e.g., a non-platform plugin creates and uses custom widget (subclass) which is based on the look of the platform, we would want to have it styled according to the theme (hence the *-rule(s) I have used).īut your argument, Brian, is valid as well: In a more general discussion, I think that CSS styling at the level we currently do will never lead to the perfect result, because what we try to achieve is a way to make Eclipse look good with light and dark themes on all platforms with maintainable and simple CSS. (Best thing would be if Andrea could help here, because he has the most knowledge about which parts are workarounds and which ones are not - this is not always clear from the CSS and it is quite some effort to get it right on all platforms). I had hoped that the overly simplified version could be fresh start to which we would add specific rules again as needed.īut I don't have objections against reverting the commit and take the original CSS and remove the workarounds for the bug which have been fixed in the meantime in there to simplify a bit. I have feared that the simplification would be too much (which is why I wanted to create an experimental additional theme to try out things in the first place. I'd like to discuss this and provide a commit still for M7 - preferably reverting the previous commit and solving merge conflicts (as the simplification didn't work IMHO) - and if not that at least fixing the bug on the "Form *," (although the final result isn't good for the preferences). it oversimplified things by creating global definitions which we can't really use if we want to be able to let the user customize the editor background color - or anything else really (I know the previous rules were much more verbose, but at least they worked well). Personally, I think that the commit should be reverted. I.e.: can you spot the comma ending: "Form *,": this mostly overrides the previous definition for this separate background which makes the editor have a lighter background meant to the preferences (this is definitely a bug is the commit which should be fixed - but if this is done, the preferences don't have the lighter background as it ends up in the previous rule which is meant for the editor). * Default fallback for any control not specified further */ The commit has some things which I consider wrong: Ok, I've investigated this a bit further and this happened due to applying the commit 62453526ec07379e36b8782df2f266924440d005īug 431845 - Simplify dark theme
0 kommentar(er)
